Output preimage saving + add Base and Arbitrum#240
Closed
Conversation
…/hdp-cairo into feat/output-preimage-saving
Okm165
requested changes
Dec 10, 2025
Collaborator
Okm165
left a comment
Okm165
left a comment
There was a problem hiding this comment.
chain enhancement is gucci
but pre-image feature imo badly designed coz we dont support nested objects serialization like arrays of arrays and many other things.
also inputs to dry-run should not include path for pre-image file for sure
lets leverage output serialization of Cairo1 for it why not just save red data of module before merkelization?
Member
|
Subset of #241 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.